Author Topic: Need some php help  (Read 1069 times)

0 Members and 1 Guest are viewing this topic.

DevilsRefugee

  • Contributor
  • Registered Forum Member
  • ***
  • Posts: 1099
  • Karma: +7/-1
  • Damn, I'm Good.
    • View Profile
    • James Wylie | Media Designer
Re: Need some php help
« Reply #15 on: June 10, 2010, 13:06:55 PM »
can you paste the original code you had on the contact.php page..

edit..

your not using target="_blank" in the link are you?  your probably not but just a question.

also your missing a
Code: [Select]
</a> on your designed by link :)


yeah sure its here:

Code: [Select]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Language" content="en-gb" />
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252" />

<meta name="keywords" content="Fancy,pigeons,quail,japanese,tuxedo,white,chinese,loft,birds,chicks,italian,Indian,fantail,capuchines,german,owl,
russian,danzig,highflyers,tumblers,rollers,archangels,helmets,frillbacks,doves,felegyhazer,eggs,showing,jarrad,luke,graham,jones,birds,nuns,aviaries,
komorner,cheap,good,quality,national Pigeon association" />

<meta name="description" content="Jones Pigeons are a family run organisation keeping fancy pigeons and quail. We keep a range of breeds of fancy pigeons and quail." />

<LINK REL=stylesheet HREF="css/style.css">

<title>Jones Pigeons | Contact Us with any questions or comments</title>
</head>

<body topmargin="0" leftmargin="0" rightmargin="0" bottommargin="0" marginwidth="0" marginheight="0" background="build/bg.gif">
<div align="center">
<table border="0" width="805" cellspacing="0" cellpadding="0">
<tr>
<td width="309">
<a href="index.html">
<img border="0" src="build/h1.jpg" width="311" height="87" title="Jones Pigeons Logo. Fancy Pigeons & Quail" alt="Jones Pigeons Logo. Click to go to home page."></a></td>
<td width="293">
<img border="0" src="build/h2.jpg" width="293" height="87"></td>
<td width="201">
<a href="contact.html">
<img border="0" src="build/h3.jpg" width="201" height="87" title="Contact Jones Pigeons" alt="Jones Pigeons. 01656 849471, Mobile 07502314377, click to go to contact page."></a></td>
</tr>
<tr>
<td width="805" colspan="3">
<img border="0" src="build/h4.jpg" width="805" height="132" title="We keep a range of breeds of fancy pigeons like capuchines, german owls, archangels, frillbacks, Indian fantails,
exhibition fantails, Russian Wolgas and danzigs"></td>
</tr>
<tr>
<td width="805" colspan="3" background="build/navbg.gif" valign="top">
<div id="navcontainer">
<ul id="navlist">
<li id="active"><a href="index.html" title="About Jones Pigeons" id="current">About</a></li>
<li><a href="info.html" title="Information about Pigeons including caring and show standards">Information</a></li>
<li><a href="gallery.html" title="Jones Pigeons photo gallery">Gallery</a></li>
<li><a href="forsale.html" title="Birds and eggs Jones Pigeons are selling">Birds for Sale</a></li>
<li><a href="links.html" title="Jones Pigeons friends and links">Links</a></li>
<li><a href="contact.html" title="Contact Jones Pigeons with any questions or comments">Contact Us</a></li>

</ul>
</div>
</td>
</tr>
</table>

<table border="0" width="805" cellspacing="0" cellpadding="0">
<tr>
<td>
<table border="0" width="805" cellspacing="0" cellpadding="0">
<tr>
<td width="561" background="build/h5.gif">
&nbsp;</td>
<td width="244" background="build/h6.gif" height="19">
&nbsp;</td>
</tr>
<tr>
<td width="561" background="build/h7.gif" valign="top" title="Contact Jones Pigeons" >
<h1 align="left">Contact Jones Pigeons<br>
</h1>
<p>We appreciate feedback and also welcome any questions you
may have. Please feel free to use the contact form, or
alternatively our contact details can be found on this page.</p>
<? include "http://www.jameswylie.co.uk/pigeons/contact/contact-form.php"; ?>
<div align="center">
<table border="0" width="80%" cellpadding="2">
<tr>
<p>
<td width="126" valign="top" align="center" bgcolor="#5183B8">
<b><font face="Verdana" size="2">Address</font></b></td></p>
<td bgcolor="#C0C0C0">
<font face="Verdana" size="2">19 River Street Ogmore Vale,
Bridgend,<br>
South Wales,
CF32 7BH
</font>
</td>
</p>
</tr>
<tr>
<td width="126" align="center" bgcolor="#5183B8">
<b><font face="Verdana" size="2">Home Contact</font></b></td>
<td bgcolor="#C0C0C0">
<font face="Verdana" size="2">01656 849471</font></td>
</tr>
<tr>
<td width="126" align="center" bgcolor="#5183B8">
<b><font face="Verdana" size="2">Mobile Contact</font></b></td>
<td bgcolor="#C0C0C0">
<font face="Verdana" size="2">07502314377</font></td>
</tr>
</table>
</div>
</td>
<td width="244" background="build/h8.gif" valign="top">
<p align="center">
<!-- Begin ShoutMix - http://www.shoutmix.com -->
<iframe title="jonespigeons" src="http://www5.shoutmix.com/?jonespigeons" width="190" height="300" frameborder="0" scrolling="auto">
<a href="http://www5.shoutmix.com/?jonespigeons">View shoutbox</a>
</iframe>
</td>
</tr>
<tr>
<td width="561" background="build/h7.gif">&nbsp;</td>
<td width="244" background="build/h8.gif">
<img border="0" src="build/h10.gif" width="244" height="23"></td>
</tr>
<tr>
<td width="561" background="build/h7.gif">
&nbsp;</td>
<td width="244" background="build/h13.gif" valign="top">
<p align="center" style="text-align: center">
<a target="_blank" href="http://www.nationalpigeonassociation.co.uk/">
<img border="0" src="build/npa.gif" width="150" height="90" align="top" title="National Pigeon Association. Click to view website." alt="National Pigeon Association. Click to view website."></a><br>
&nbsp;
<a href="http://jigsaw.w3.org/css-validator/check/referer">
        <img style="border:0;width:88px;height:31px"
            src="http://jigsaw.w3.org/css-validator/images/vcss"
            alt="Valid CSS!" />
    </a>
</td>
</tr>
<tr>
<td width="561" background="build/h7.gif">
<img border="0" src="build/h9.gif" width="561" height="23"></td>
<td width="244" background="build/h13.gif">&nbsp;</td>
</tr>
<tr>
<td width="561" background="build/h11.gif" align="center" valign="top" height="40">
<footer>© 2010 Jones Pigeons. All Rights Reserved. | Site Map | Designed by <a target="_blank" href="http://www.jameswylie.co.uk">James Wylie</footer>
<br>
&nbsp;</td>
<td width="244" background="build/h12.gif" height="38" align="center" valign="top">
&nbsp;
</td>
</tr>
<tr>
<td width="561" align="center" valign="top" height="20">
&nbsp;</td>
<td width="244" height="20" align="center" valign="top">
&nbsp;</td>
</tr>
</table>
</td>
</tr>
</table>
</div>
</body>
</html>

haha not the best at coding as you can see..will fix the </a> link now, but you may spot one or 3million more little flaws like that, but for 60 quid im not losing to much sleep over it  ;)
My Youtube page of goodies!
-------------------------------------

Humbug

  • Community Leaders
  • Registered Forum Member
  • ******
  • Posts: 4416
  • Karma: +36/-6
    • View Profile
Re: Need some php help
« Reply #16 on: June 10, 2010, 13:13:44 PM »
i meant the original code before you altered it to this

Code: [Select]
<? include "http://www.jameswylie.co.uk/pigeons/contact/contact-form.php"; ?>
Cheers and Good Game

Humbug


DevilsRefugee

  • Contributor
  • Registered Forum Member
  • ***
  • Posts: 1099
  • Karma: +7/-1
  • Damn, I'm Good.
    • View Profile
    • James Wylie | Media Designer
Re: Need some php help
« Reply #17 on: June 10, 2010, 13:19:24 PM »
i meant the original code before you altered it to this

Code: [Select]
<? include "http://www.jameswylie.co.uk/pigeons/contact/contact-form.php"; ?>

you mean with the "<p>Click here to open our <a href="contact/contact-form.php"> contact form</a>.</p>"

or something else??

included the code with the original textual link in and lol at the forum changing the html markup :D


Code: [Select]
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Language" content="en-gb" />
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252" />

<meta name="keywords" content="Fancy,pigeons,quail,japanese,tuxedo,white,chinese,loft,birds,chicks,italian,Indian,fantail,capuchines,german,owl,
russian,danzig,highflyers,tumblers,rollers,archangels,helmets,frillbacks,doves,felegyhazer,eggs,showing,jarrad,luke,graham,jones,birds,nuns,aviaries,
komorner,cheap,good,quality,national Pigeon association" />

<meta name="description" content="Jones Pigeons are a family run organisation keeping fancy pigeons and quail. We keep a range of breeds of fancy pigeons and quail." />

<LINK REL=stylesheet HREF="css/style.css">

<title>Jones Pigeons | Contact Us with any questions or comments</title>
</head>

<body topmargin="0" leftmargin="0" rightmargin="0" bottommargin="0" marginwidth="0" marginheight="0" background="build/bg.gif">
<div align="center">
<table border="0" width="805" cellspacing="0" cellpadding="0">
<tr>
<td width="309">
<a href="index.html">
<img border="0" src="build/h1.jpg" width="311" height="87" title="Jones Pigeons Logo. Fancy Pigeons & Quail" alt="Jones Pigeons Logo. Click to go to home page."></a></td>
<td width="293">
<img border="0" src="build/h2.jpg" width="293" height="87"></td>
<td width="201">
<a href="contact.html">
<img border="0" src="build/h3.jpg" width="201" height="87" title="Contact Jones Pigeons" alt="Jones Pigeons. 01656 849471, Mobile 07502314377, click to go to contact page."></a></td>
</tr>
<tr>
<td width="805" colspan="3">
<img border="0" src="build/h4.jpg" width="805" height="132" title="We keep a range of breeds of fancy pigeons like capuchines, german owls, archangels, frillbacks, Indian fantails,
exhibition fantails, Russian Wolgas and danzigs"></td>
</tr>
<tr>
<td width="805" colspan="3" background="build/navbg.gif" valign="top">
<div id="navcontainer">
<ul id="navlist">
<li id="active"><a href="index.html" title="About Jones Pigeons" id="current">About</a></li>
<li><a href="info.html" title="Information about Pigeons including caring and show standards">Information</a></li>
<li><a href="gallery.html" title="Jones Pigeons photo gallery">Gallery</a></li>
<li><a href="forsale.html" title="Birds and eggs Jones Pigeons are selling">Birds for Sale</a></li>
<li><a href="links.html" title="Jones Pigeons friends and links">Links</a></li>
<li><a href="contact.html" title="Contact Jones Pigeons with any questions or comments">Contact Us</a></li>

</ul>
</div>
</td>
</tr>
</table>

<table border="0" width="805" cellspacing="0" cellpadding="0">
<tr>
<td>
<table border="0" width="805" cellspacing="0" cellpadding="0">
<tr>
<td width="561" background="build/h5.gif">
&nbsp;</td>
<td width="244" background="build/h6.gif" height="19">
&nbsp;</td>
</tr>
<tr>
<td width="561" background="build/h7.gif" valign="top" title="Contact Jones Pigeons" >
<h1 align="left">Contact Jones Pigeons<br>
</h1>
<p>We appreciate feedback and also welcome any questions you
may have. Please feel free to use the contact form, or
alternatively our contact details can be found on this page.</p>
<p>Click here to open our <a href="contact/contact-form.php"> contact form</a>.</p>
<div align="center">
<table border="0" width="80%" cellpadding="2">
<tr>
<p>
<td width="126" valign="top" align="center" bgcolor="#5183B8">
<b><font face="Verdana" size="2">Address</font></b></td></p>
<td bgcolor="#C0C0C0">
<font face="Verdana" size="2">19 River Street Ogmore Vale,
Bridgend,<br>
South Wales,
CF32 7BH
</font>
</td>
</p>
</tr>
<tr>
<td width="126" align="center" bgcolor="#5183B8">
<b><font face="Verdana" size="2">Home Contact</font></b></td>
<td bgcolor="#C0C0C0">
<font face="Verdana" size="2">01656 849471</font></td>
</tr>
<tr>
<td width="126" align="center" bgcolor="#5183B8">
<b><font face="Verdana" size="2">Mobile Contact</font></b></td>
<td bgcolor="#C0C0C0">
<font face="Verdana" size="2">07502314377</font></td>
</tr>
</table>
</div>
</td>
<td width="244" background="build/h8.gif" valign="top">
<p align="center">
<!-- Begin ShoutMix - http://www.shoutmix.com -->
<iframe title="jonespigeons" src="http://www5.shoutmix.com/?jonespigeons" width="190" height="300" frameborder="0" scrolling="auto">
<a href="http://www5.shoutmix.com/?jonespigeons">View shoutbox</a>
</iframe>
</td>
</tr>
<tr>
<td width="561" background="build/h7.gif">&nbsp;</td>
<td width="244" background="build/h8.gif">
<img border="0" src="build/h10.gif" width="244" height="23"></td>
</tr>
<tr>
<td width="561" background="build/h7.gif">
&nbsp;</td>
<td width="244" background="build/h13.gif" valign="top">
<p align="center" style="text-align: center">
<a target="_blank" href="http://www.nationalpigeonassociation.co.uk/">
<img border="0" src="build/npa.gif" width="150" height="90" align="top" title="National Pigeon Association. Click to view website." alt="National Pigeon Association. Click to view website."></a><br>
&nbsp;
<a href="http://jigsaw.w3.org/css-validator/check/referer">
        <img style="border:0;width:88px;height:31px"
            src="http://jigsaw.w3.org/css-validator/images/vcss"
            alt="Valid CSS!" />
    </a>
</td>
</tr>
<tr>
<td width="561" background="build/h7.gif">
<img border="0" src="build/h9.gif" width="561" height="23"></td>
<td width="244" background="build/h13.gif">&nbsp;</td>
</tr>
<tr>
<td width="561" background="build/h11.gif" align="center" valign="top" height="40">
<footer>© 2010 Jones Pigeons. All Rights Reserved. | Site Map | Designed by <a target="_blank" href="http://www.jameswylie.co.uk">James Wylie</footer>
<br>
&nbsp;</td>
<td width="244" background="build/h12.gif" height="38" align="center" valign="top">
&nbsp;
</td>
</tr>
<tr>
<td width="561" align="center" valign="top" height="20">
&nbsp;</td>
<td width="244" height="20" align="center" valign="top">
&nbsp;</td>
</tr>
</table>
</td>
</tr>
</table>
</div>
</body>
</html>
« Last Edit: June 10, 2010, 13:22:19 PM by DevilsRefugee »
My Youtube page of goodies!
-------------------------------------

frymaster

  • Community officer
  • Contributor
  • Registered Forum Member
  • ***
  • Posts: 2194
  • Karma: +44/-7
  • Your argument is invalid, you are a squirrel
    • View Profile
Re: Need some php help
« Reply #18 on: June 10, 2010, 13:25:01 PM »
yeah but i dont want the contact form opening a new page


if by form you mean the http://www.jameswylie.co.uk/pigeons/contact/contact-form.php bit, I don't think it does open a new page.
In the original thing you had, the thing that linked to it was opening it in a new page, however

also: I notice you've chosen to use xhtml transitional.  If you're going to use this, you need to make sure your page validates.  That means getting rid of random <TAGS IN CAPITALS> (xhtml is lower-case only),  making sure tags with no end tag are <self-closing/> , not using random stuff in the body tag like "topmargin" etc. (because they don't exist) and so on

it is much easier to keep it valid as you go, rather than hack the page together and then try to make it valid because browsers behave differently on dodgy pages - they enable all sorts of random compatability pish

http://validator.w3.org/check?verbose=1&uri=http%3a%2f%2fwww.jameswylie.co.uk%2fpigeons%2findex.html

p.s. fruitbat mentioned keeping case the same... i.e. the web URL you are using is /pigeons but looking at the error messages you're getting, the directory name is /Pigeons - just because windows web server happens to not care doesn't mean other things will be the same, and apart from anything else, if you don't use the right casing, things will break if he ever moves his website to apache
« Last Edit: June 10, 2010, 13:30:54 PM by frymaster »

DevilsRefugee

  • Contributor
  • Registered Forum Member
  • ***
  • Posts: 1099
  • Karma: +7/-1
  • Damn, I'm Good.
    • View Profile
    • James Wylie | Media Designer
Re: Need some php help
« Reply #19 on: June 10, 2010, 13:54:23 PM »
yeah but i dont want the contact form opening a new page


if by form you mean the http://www.jameswylie.co.uk/pigeons/contact/contact-form.php bit, I don't think it does open a new page.
In the original thing you had, the thing that linked to it was opening it in a new page, however

also: I notice you've chosen to use xhtml transitional.  If you're going to use this, you need to make sure your page validates.  That means getting rid of random <TAGS IN CAPITALS> (xhtml is lower-case only),  making sure tags with no end tag are <self-closing/> , not using random stuff in the body tag like "topmargin" etc. (because they don't exist) and so on

it is much easier to keep it valid as you go, rather than hack the page together and then try to make it valid because browsers behave differently on dodgy pages - they enable all sorts of random compatability pish

http://validator.w3.org/check?verbose=1&uri=http%3a%2f%2fwww.jameswylie.co.uk%2fpigeons%2findex.html

p.s. fruitbat mentioned keeping case the same... i.e. the web URL you are using is /pigeons but looking at the error messages you're getting, the directory name is /Pigeons - just because windows web server happens to not care doesn't mean other things will be the same, and apart from anything else, if you don't use the right casing, things will break if he ever moves his website to apache


yeah im not overly fussed on the whole vaildation, i never chose it wanky frontpage did. I get why people prefer it to be done, but imo if they made reading the error more "noobish" then i could correct my errors.

atm im more concerned with getting a suitable contact form working rather than making the site sing and dance in any and every browser. It works for the big ones, firefox and explorer and that (for now is good enough for me like) lets not forget this is a bargain site.

But thanks for the headsup..

for example:

Line 13, Column 1: start tag was here

<LINK REL=stylesheet HREF="css/style.css">

and thats all it says, yet i dont get what is wrong with it, unless its the LINK REL being in upper case.. :/
My Youtube page of goodies!
-------------------------------------

DevilsRefugee

  • Contributor
  • Registered Forum Member
  • ***
  • Posts: 1099
  • Karma: +7/-1
  • Damn, I'm Good.
    • View Profile
    • James Wylie | Media Designer
Re: Need some php help
« Reply #20 on: June 10, 2010, 13:57:50 PM »
yeah but i dont want the contact form opening a new page


if by form you mean the http://www.jameswylie.co.uk/pigeons/contact/contact-form.php bit, I don't think it does open a new page.
In the original thing you had, the thing that linked to it was opening it in a new page, however

also: I notice you've chosen to use xhtml transitional.  If you're going to use this, you need to make sure your page validates.  That means getting rid of random <TAGS IN CAPITALS> (xhtml is lower-case only),  making sure tags with no end tag are <self-closing/> , not using random stuff in the body tag like "topmargin" etc. (because they don't exist) and so on

it is much easier to keep it valid as you go, rather than hack the page together and then try to make it valid because browsers behave differently on dodgy pages - they enable all sorts of random compatability pish

http://validator.w3.org/check?verbose=1&uri=http%3a%2f%2fwww.jameswylie.co.uk%2fpigeons%2findex.html

p.s. fruitbat mentioned keeping case the same... i.e. the web URL you are using is /pigeons but looking at the error messages you're getting, the directory name is /Pigeons - just because windows web server happens to not care doesn't mean other things will be the same, and apart from anything else, if you don't use the right casing, things will break if he ever moves his website to apache


yeah im not overly fussed on the whole vaildation, i never chose it wanky frontpage did. I get why people prefer it to be done, but imo if they made reading the error more "noobish" then i could correct my errors.

atm im more concerned with getting a suitable contact form working rather than making the site sing and dance in any and every browser. It works for the big ones, firefox and explorer and that (for now is good enough for me like) lets not forget this is a bargain site.

But thanks for the headsup..

for example:

Line 13, Column 1: start tag was here

<LINK REL=stylesheet HREF="css/style.css">

and thats all it says, yet i dont get what is wrong with it, unless its the LINK REL being in upper case.. :/


also just re-read your post and i needed to have the top margin=0 because the editor actually puts the table like 5 pixels from the top and i wanted it to display right at the top, so things like that im not really to sure about. Ive been out of the game for several years and the guy this site is for wants it all singing and all dancing for a measly 60 pound. I mean he even wants a cms photo gallery..sometimes it sucks, but once ive got one done i will have learnt some valuable lessons :)

edit

lol quoted myself when i meant to modify..would fix but gotta go to work now

thanks for the advice and help so far, its really appreciated :)
« Last Edit: June 10, 2010, 13:59:49 PM by DevilsRefugee »
My Youtube page of goodies!
-------------------------------------

frymaster

  • Community officer
  • Contributor
  • Registered Forum Member
  • ***
  • Posts: 2194
  • Karma: +44/-7
  • Your argument is invalid, you are a squirrel
    • View Profile
Re: Need some php help
« Reply #21 on: June 10, 2010, 15:15:58 PM »
for example:

Line 13, Column 1: start tag was here

<LINK REL=stylesheet HREF="css/style.css">

and thats all it says, yet i dont get what is wrong with it, unless its the LINK REL being in upper case.. :/

no, that's not all it says :P

the line above says:
"Line 15, Column 7: end tag for "LINK" omitted, but OMITTAG NO was specified "

the line you're reading is saying where it started

i.e. it's saying

- "LINK was opened and not closed" (I'm saying this because the thing it was contained in is now being closed)
    - "it was opened here"

Basically you only want to look at error lines, not info lines

you don't need to stick random margin attribute stuff in the body tag because you can just change the margins of the body with CSS (or you could say style="margin....." in the tag, but since you've got a css page already i'd just use it)

I know you say it works in major browsers, but have you tested all versions of those browsers?  If it's valid, it's a lot less likely to randomly act wierdly for no good reason. Also, invalid pages get a lower rank on search engines, and if you're going to charge money for this I'd say you're obliged to do the job properly.

Any particular reason you're using frontpage?  It was discontinued in 2003 and the sucessor (expression web) is much better
« Last Edit: June 10, 2010, 15:27:35 PM by frymaster »

DevilsRefugee

  • Contributor
  • Registered Forum Member
  • ***
  • Posts: 1099
  • Karma: +7/-1
  • Damn, I'm Good.
    • View Profile
    • James Wylie | Media Designer
Re: Need some php help
« Reply #22 on: June 10, 2010, 20:10:55 PM »
well the search engine stuff he didnt want to pay for, so to get the job i said i would just do the basics of SEO (meta data and titles and ALT attributes) and a submission to google.

I know what your saying about validation, its just never been my strong point (as you can tell  :P ) im more of a designer than a developer..but i will try and go through it before it goes live (just so i learn a bit more about more than anything else.

I use fp because i dont like DW and never knew of the new stuff ms have released and fp is good for me because it means i dont have to waste time learning a new WYSIWYG editor - but i will look into that new one, thanks :)
My Youtube page of goodies!
-------------------------------------

DevilsRefugee

  • Contributor
  • Registered Forum Member
  • ***
  • Posts: 1099
  • Karma: +7/-1
  • Damn, I'm Good.
    • View Profile
    • James Wylie | Media Designer
Re: Need some php help
« Reply #23 on: June 15, 2010, 13:11:48 PM »
ok, fixed my contact form, but i keep getting :

Notice: Undefined variable: error1 in \\nas44ent\domains\j\jameswylie.co.uk\user\htdocs\Pigeons\contact.php on line 201

I know its just a notice and doesnt actually stop the script, but i would like to either fix it, or not make it display. To not make it display, i know i gotta edit php.ini on the web server, but i would rather fix it than make it not show..

how would one do this?

thanks.
My Youtube page of goodies!
-------------------------------------